[Solved] making a shell with C

Your third argument (a[2]) has a newline character at the end. ls thus complains that it can’t find a directory named with a single newline character under your home directory. Fix your command parsing to not include the newline.