Initially you set:
int menu_choice = 0;
Then you ask:
if (menu_choice < 1 || menu_choice > 4 )
The choice is smaller than 1
so the if block
is entered.
You then get some user input and exit the application.
3
solved Condition is not evaluated in loop