{"id":9307,"date":"2022-09-18T07:44:43","date_gmt":"2022-09-18T02:14:43","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/"},"modified":"2022-09-18T07:44:43","modified_gmt":"2022-09-18T02:14:43","slug":"solved-why-my-output-isnt-correct","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/","title":{"rendered":"[Solved] Why my output isn’t correct?"},"content":{"rendered":"

[ad_1]
\n<\/p>\n

\n
\n
<\/div>\n
\n
\n

I commented the changed portion and explained why. I didn’t change your code, so that you can understand easily. <\/p>\n

Try this :<\/p>\n

#include <stdio.h>\n#include <stdlib.h>\n#include <string.h>\n\nstruct AdjListNode\n{\n    char *dest;\n    struct AdjListNode* next;\n};\n\nstruct AdjList\n{\n    struct AdjListNode *head;  \/\/ pointer to head node of list\n};\n\nstruct Graph\n{\n    int V;\n    struct AdjList* array;\n};\n\nstruct AdjListNode* newAdjListNode(char *dest)\n{\n    struct AdjListNode* newNode = (struct AdjListNode*) malloc(sizeof(struct AdjListNode));\n    newNode->dest = dest;\n    newNode->next = NULL;\n    return newNode;\n}\n\nstruct Graph* createGraph(int V)\n{\n    struct Graph* graph = (struct Graph*) malloc(sizeof(struct Graph));\n    graph->V = V;\n\n    \/\/ Create an array of adjacency lists.  Size of array will be V\n    graph->array = (struct AdjList*) malloc(V * sizeof(struct AdjList));\n\n    \/\/ Initialize each adjacency list as empty by making head as NULL\n    int i;\n    for (i = 0; i < V; ++i)\n        graph->array[i].head = NULL;\n\n    return graph;\n}\n\nvoid addEdge(struct Graph* graph, char *src, char *dest)\n{\n    \/\/ Add an edge from src to dest.  A new node is added to the adjacency\n    \/\/ list of src.  The node is added at the beginin\n\n    struct AdjListNode* newNode = newAdjListNode(dest);\n\n    \/\/***Changed. you need to add edge in src node. But you were always adding in 0\n    newNode->next = graph->array[src[0]-'a'].head;\n    graph->array[src[0]-'a'].head = newNode;\n\n    \/\/ Since graph is undirected, add an edge from dest to src also\n    newNode = newAdjListNode(src);\n\n    \/\/***Changed. you need to add edge in dest node. But you were always adding in 1\n    newNode->next = graph->array[dest[0]-'a'].head;\n    graph->array[dest[0]-'a'].head = newNode;\n}\n\nvoid printGraph(struct Graph* graph)\n{\n    int v;\n    for (v = 0; v < graph->V; ++v)\n    {\n        struct AdjListNode* pCrawl = graph->array[v].head;\n        printf(\"\\n Adjacency list of vertex %d\\n head %c\", v, v + 'a');\n        while (pCrawl)\n        {\n            printf(\"-> %s\", pCrawl->dest);\n            pCrawl = pCrawl->next;\n        }\n        printf(\"\\n\");\n    }\n}\n\nint main()\n{\n    \/\/ create the graph given in above fugure\n    int V = 5;\n    struct Graph* graph = createGraph(V);\n    addEdge(graph, \"a\", \"b\");\n    addEdge(graph, \"a\", \"e\");\n    addEdge(graph, \"b\", \"c\");\n    addEdge(graph, \"b\", \"d\" );\n    addEdge(graph, \"b\", \"e\");\n    addEdge(graph, \"c\", \"d\");\n    addEdge(graph, \"d\", \"e\");\n\n\n    \/\/ print the adjacency list representation of the above graph\n    printGraph(graph);\n\n    return 0;\n}\n<\/code><\/pre>\n
It will give you output :<\/p>\n
a-> e-> b\nb-> e-> d-> c-> a\nc-> d-> b\nd-> e-> c-> b\ne-> d-> b-> a\n<\/code><\/pre>\n
And if you want to get exact same output like this :<\/p>\n
a-> b-> e\nb-> a-> c-> d-> e\nc-> b-> d\nd-> b-> c-> e\ne-> a-> b-> d\n<\/code><\/pre>\n
just change the addEdge() function following way :<\/p>\n
void addEdge(struct Graph* graph, char *src, char *dest)\n{\n    \/\/ Add an edge from src to dest.  A new node is added to the adjacency\n    \/\/ list of src.  The node is added at the beginin\n\n    struct AdjListNode* newNode = newAdjListNode(dest);\n\n    \/\/***Changed. you need to add adge in src node. But you were always adding in 0\n    struct AdjListNode* temp=graph->array[src[0]-'a'].head;\n\n    if(temp==NULL)  \/\/ First element of the list\n      graph->array[src[0]-'a'].head=newNode;\n    else\n    {\n        while(temp->next!=NULL) \/\/ finding the last element of the list\n            temp=temp->next;\n        temp->next=newNode; \/\/ Adding current element to the last\n    }\n\n    \/\/ Since graph is undirected, add an edge from dest to src also\n    newNode = newAdjListNode(src);\n\n    \/\/***Changed. you need to add adge in dest node. But you were always adding in 1\n    temp = graph->array[dest[0]-'a'].head;\n\n    if(temp==NULL) \/\/ First element of the list\n      graph->array[dest[0]-'a'].head=newNode;\n    else\n    {\n        while(temp->next!=NULL) \/\/ finding the last element of the list\n            temp=temp->next;\n        temp->next=newNode; \/\/ Adding current element to the last\n    }\n}\n<\/code><\/pre>\n
1st code will add new edge at front and 2nd code will add it at last.
\nHope it helps \ud83d\ude42<\/p>\n<\/p><\/div>\n
<\/div>\n<\/div>\n
            2<\/span> <\/p><\/div>\n<\/div>\n
[ad_2]<\/p>\n
solved Why my output isn’t correct? <\/p>\n","protected":false},"excerpt":{"rendered":"
[ad_1] I commented the changed portion and explained why. I didn’t change your code, so that you can understand easily. Try this : #include <stdio.h> #include <stdlib.h> #include <string.h> struct AdjListNode { char *dest; struct AdjListNode* next; }; struct AdjList { struct AdjListNode *head; \/\/ pointer to head node of list }; struct Graph { … Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324,859,771],"class_list":["post-9307","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c","tag-data-structures","tag-graph"],"yoast_head":"\n[Solved] Why my output isn't correct? - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] Why my output isn't correct? - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] I commented the changed portion and explained why. I didn’t change your code, so that you can understand easily. Try this : #include <stdio.h> #include <stdlib.h> #include <string.h> struct AdjListNode { char *dest; struct AdjListNode* next; }; struct AdjList { struct AdjListNode *head; \/\/ pointer to head node of list }; struct Graph { ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2022-09-18T02:14:43+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"3 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] Why my output isn’t correct?\",\"datePublished\":\"2022-09-18T02:14:43+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/\"},\"wordCount\":80,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"c++\",\"data-structures\",\"graph\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/\",\"name\":\"[Solved] Why my output isn't correct? - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2022-09-18T02:14:43+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] Why my output isn’t correct?\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] Why my output isn't correct? - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] Why my output isn't correct? - JassWeb","og_description":"[ad_1] I commented the changed portion and explained why. I didn’t change your code, so that you can understand easily. Try this : #include <stdio.h> #include <stdlib.h> #include <string.h> struct AdjListNode { char *dest; struct AdjListNode* next; }; struct AdjList { struct AdjListNode *head; \/\/ pointer to head node of list }; struct Graph { ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/","og_site_name":"JassWeb","article_published_time":"2022-09-18T02:14:43+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"3 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] Why my output isn’t correct?","datePublished":"2022-09-18T02:14:43+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/"},"wordCount":80,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++","data-structures","graph"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/","url":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/","name":"[Solved] Why my output isn't correct? - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2022-09-18T02:14:43+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-why-my-output-isnt-correct\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] Why my output isn’t correct?"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/9307","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=9307"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/9307\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=9307"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=9307"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=9307"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}