{"id":6727,"date":"2022-09-04T20:25:18","date_gmt":"2022-09-04T14:55:18","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-dynamic-memory-allocation-fault\/"},"modified":"2022-09-04T20:25:18","modified_gmt":"2022-09-04T14:55:18","slug":"solved-dynamic-memory-allocation-fault","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-dynamic-memory-allocation-fault\/","title":{"rendered":"[Solved] Dynamic Memory allocation fault"},"content":{"rendered":"

[ad_1]
\n<\/p>\n

\n
\n
<\/div>\n
\n
\n

The issue is that n<\/code> keeps growing, but your array does not.<\/p>\n

This code invokes undefined behavior, which thankfully caused a segfault for you:<\/p>\n

while(ch=='y')\n{   n++;  cout<<\"Enter 1 more element: \";   cin>>arr[n];\n    cout<<\"Want to enter more? \";       cin>>ch;\n}\n<\/code><\/pre>\n
arr<\/code> has only been allocated to store n<\/code> elements. Simply writing past the end will not automatically reallocate. You’re looking for a std::vector<\/code><\/a>, which will additionally save you the hassle of explicitly allocating\/deallocating anything.<\/p>\n
You can accomplish what you want like so (untested):<\/p>\n
#include <iostream>\n#include <vector>\nusing namespace std;\nint main()\n{\n    int n;  char ch=\"y\";\n    cout<<\"Enter size of array: \";\n    cin>>n;\n    std::vector<int> arr(n);\n    cout<<\"Enter elements: \";\n    for(int i=0;i<n;++i) cin>>arr[i];\n\n    \/\/...\n\n    while(ch=='y')\n    {   n++;  cout<<\"Enter 1 more element: \";\n        int tmp;\n        cin>>tmp;\n        arr.emplace_back(tmp)\n        cout<<\"Want to enter more? \";       cin>>ch;\n    }\n    cout<<\"All elements are: \"; \n    for(int element : arr)\n       cout<< element <<\"  \";\n\n    return 0;\n}\n<\/code><\/pre>\n