{"id":34084,"date":"2023-02-25T04:23:16","date_gmt":"2023-02-24T22:53:16","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/"},"modified":"2023-02-25T04:23:16","modified_gmt":"2023-02-24T22:53:16","slug":"solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/","title":{"rendered":"[Solved] Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed]"},"content":{"rendered":"<p> [ad_1]<br \/>\n<\/p>\n<div id=\"answer-75001760\" class=\"answer js-answer accepted-answer js-accepted-answer\" data-answerid=\"75001760\" data-parentid=\"75001513\" data-score=\"-1\" data-position-on-page=\"1\" data-highest-scored=\"1\" data-question-has-accepted-highest-score=\"1\" itemprop=\"acceptedAnswer\" itemscope itemtype=\"https:\/\/schema.org\/Answer\">\n<div class=\"post-layout\">\n<div class=\"votecell post-layout--left\"><\/div>\n<div class=\"answercell post-layout--right\">\n<div class=\"s-prose js-post-body\" itemprop=\"text\">\n<ol>\n<li>\n<p>You are casting <code>(bool) valid_triangel<\/code> the address of the function instead of calling it.  This will always be non-NULL and the corresponding true branch of the if condition will be executed irregardless of input.<\/p>\n<\/li>\n<li>\n<p>(non-issue) I don&#8217;t have cs50.h installed so I wrote a quick <code>get_double()<\/code> to test your code.<\/p>\n<\/li>\n<li>\n<p>Removed the declaration of <code>valid_tringel()<\/code> inside <code>main()<\/code>.<\/p>\n<\/li>\n<li>\n<p>Fixed typo (triangle).<\/p>\n<\/li>\n<li>\n<p><code>(x + y &gt;= z )  || (x + z &gt;= y) || (z + y &gt;= x )<\/code> is inverted in <code>valid_triangle()<\/code>.  As you return boolean just express is directly instead of an <code>if<\/code> condition:<\/p>\n<\/li>\n<\/ol>\n<blockquote>\n<p>According to the first triangle inequality theorem, the lengths of any two sides of a triangle must add up to more than the length of the third side.<a rel=\"nofollow noopener\" target=\"_blank\" href=\"https:\/\/sciencing.com\/rules-length-triangle-sides-8606207.html\">1<\/a><\/p>\n<\/blockquote>\n<ol start=\"5\">\n<li>Used early return style in <code>main()<\/code> so the normal case is not indented (purely a matter of style).<\/li>\n<\/ol>\n<pre><code>#include &lt;stdio.h&gt;\n#include &lt;stdbool.h&gt;\n\ndouble get_double(const char *s) {\n    printf(\"%s\", s);\n    double d;\n    scanf(\"%lf\", &amp;d);\n    return d;\n}\n\nbool valid_triangle(double x, double y, double z) {\n    return\n        x &gt; 0 &amp;&amp;\n        y &gt; 0 &amp;&amp;\n        z &gt; 0 &amp;&amp;\n        x + y &gt; z &amp;&amp;\n        x + z &gt; y &amp;&amp;\n        z + y &gt; x;\n}\n\nint main(void) {\n    double a = get_double(\"give me first length : \");\n    double b = get_double(\"give me second length : \");\n    double c = get_double(\"give me third length : \");\n    if(!valid_triangle(a, b, c)) {\n        printf(\"THIS IS NOT VALID\\n\");\n        return 0;\n    }\n    printf(\"THAT IS A TRIANGLE\\n\");\n}\n<\/code><\/pre>\n<p>and here is example output:<\/p>\n<pre><code>give me first length : -1\ngive me second length : 1\ngive me third length : 10\nTHIS IS NOT VALID\n\ngive me first length : 1\ngive me second length : 2\ngive me third length : 3\nTHIS IS NOT VALID\n\ngive me first length : 7\ngive me second length : 10\ngive me third length : 5\nTHAT IS A TRIANGLE\n<\/code><\/pre>\n<\/p><\/div>\n<div class=\"mt24\"><\/div>\n<\/div>\n<p>            <span class=\"d-none\" itemprop=\"commentCount\"><\/span> <\/p><\/div>\n<\/div>\n<p>[ad_2]<\/p>\n<p>solved Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed] <\/p>\n","protected":false},"excerpt":{"rendered":"<p>[ad_1] You are casting (bool) valid_triangel the address of the function instead of calling it. This will always be non-NULL and the corresponding true branch of the if condition will be executed irregardless of input. (non-issue) I don&#8217;t have cs50.h installed so I wrote a quick get_double() to test your code. Removed the declaration of &#8230; <a title=\"[Solved] Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed]\" class=\"read-more\" href=\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\" aria-label=\"More on [Solved] Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed]\">Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324,816,413],"class_list":["post-34084","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c","tag-cs50","tag-function"],"yoast_head":"<!-- This site is optimized with the Yoast SEO plugin v26.5 - https:\/\/yoast.com\/wordpress\/plugins\/seo\/ -->\n<title>[Solved] Every time I start the project always just writes that &quot; THIS IS NOT VALID&quot; even if the numbers that I give are right [closed] - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] Every time I start the project always just writes that &quot; THIS IS NOT VALID&quot; even if the numbers that I give are right [closed] - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] You are casting (bool) valid_triangel the address of the function instead of calling it. This will always be non-NULL and the corresponding true branch of the if condition will be executed irregardless of input. (non-issue) I don&#8217;t have cs50.h installed so I wrote a quick get_double() to test your code. Removed the declaration of ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2023-02-24T22:53:16+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"2 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed]\",\"datePublished\":\"2023-02-24T22:53:16+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\"},\"wordCount\":174,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"c++\",\"cs50\",\"function\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\",\"name\":\"[Solved] Every time I start the project always just writes that \\\" THIS IS NOT VALID\\\" even if the numbers that I give are right [closed] - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2023-02-24T22:53:16+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed]\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] Every time I start the project always just writes that \" THIS IS NOT VALID\" even if the numbers that I give are right [closed] - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] Every time I start the project always just writes that \" THIS IS NOT VALID\" even if the numbers that I give are right [closed] - JassWeb","og_description":"[ad_1] You are casting (bool) valid_triangel the address of the function instead of calling it. This will always be non-NULL and the corresponding true branch of the if condition will be executed irregardless of input. (non-issue) I don&#8217;t have cs50.h installed so I wrote a quick get_double() to test your code. Removed the declaration of ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/","og_site_name":"JassWeb","article_published_time":"2023-02-24T22:53:16+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"2 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed]","datePublished":"2023-02-24T22:53:16+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/"},"wordCount":174,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++","cs50","function"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/","url":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/","name":"[Solved] Every time I start the project always just writes that \" THIS IS NOT VALID\" even if the numbers that I give are right [closed] - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2023-02-24T22:53:16+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-every-time-i-start-the-project-always-just-writes-that-this-is-not-valid-even-if-the-numbers-that-i-give-are-right-closed\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] Every time I start the project always just writes that &#8221; THIS IS NOT VALID&#8221; even if the numbers that I give are right [closed]"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/34084","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=34084"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/34084\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=34084"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=34084"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=34084"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}