{"id":30688,"date":"2023-01-16T12:01:43","date_gmt":"2023-01-16T06:31:43","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/"},"modified":"2023-01-16T12:01:43","modified_gmt":"2023-01-16T06:31:43","slug":"solved-valgrind-getting-strange-error","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/","title":{"rendered":"[Solved] Valgrind getting strange error"},"content":{"rendered":"<p> [ad_1]<br \/>\n<\/p>\n<div id=\"answer-30808307\" class=\"answer js-answer accepted-answer js-accepted-answer\" data-answerid=\"30808307\" data-parentid=\"30807807\" data-score=\"1\" data-position-on-page=\"1\" data-highest-scored=\"1\" data-question-has-accepted-highest-score=\"1\" itemprop=\"acceptedAnswer\" itemscope itemtype=\"https:\/\/schema.org\/Answer\">\n<div class=\"post-layout\">\n<div class=\"votecell post-layout--left\"><\/div>\n<div class=\"answercell post-layout--right\">\n<div class=\"s-prose js-post-body\" itemprop=\"text\">\n<p>First of all and most importantly: This is <strong>not<\/strong> good C++ code, not even decent. For example, some of your <code>#includes<\/code> are wrong, like <code>&lt;stdio.h&gt;<\/code> should be <code>&lt;cstdio&gt;<\/code> instead. The worst thing here are those <code>#define<\/code>s that make your code utterly unreadable. You <strong><em>really<\/em><\/strong> should read a good book on C++!<\/p>\n<hr>\n<p>For better readability I produced the pre-processor output of your code (minus the includes of course). It looks like this:<\/p>\n<pre><code>template&lt;class A&gt; std::string str(A a) { std::stringstream ss; ss&lt;&lt;a; return ss.str(); }\ntemplate&lt;class A, class ... B&gt; std::string str(A a, B...b) { std::stringstream ss; ss&lt;&lt;a&lt;&lt;str(b...); return ss.str(); }\ntemplate&lt;class A, class X&gt;\nvoid add(std::map&lt;std::string,int&gt; &amp;m, X x, A a) { if(strncmp(a,x,(new std::string(a))-&gt;length())==0)m[a] += atoi(strchr(x,':')+1);}\ntemplate&lt;class A, class X, class ... B&gt;\nvoid add(std::map&lt;std::string,int&gt; &amp;m, X x, A a, B...b) { if(strncmp(a,x,(new std::string(a))-&gt;length())==0)m[a] += atoi(strchr(x,':')+1); add(m, x, b...); }\n\nconst char* name() { return str(\"\/proc\/\",getpid(),\"\/smaps\").c_str(); }\n\nint main(int __attribute__((unused)) argc, char __attribute__((unused)) *args[])\n{\n    char b[256];\n    std::map&lt;std::string,int&gt; m;\n\n    FILE *fp = fopen(name(), \"r\");\n        while(fgets(b, 256, fp))\n            add(m,b,\"Rss\",\"Shared\",\"Private\",\"Swap\",\"Pss\",\"Referenced\");\n\n        for(auto it : m) { auto a = it.first; auto b = it.second;\n            int value = b;\n            fprintf(stderr, \"%s: %d\\n\", a.c_str(), b);\n        }\n    fclose(fp);\n\n    return 1;\n}\n<\/code><\/pre>\n<p>The line causing the error is <\/p>\n<pre><code>FILE *fp = fopen(name(), \"r\");\n<\/code><\/pre>\n<p>This is invalid because you pass a pointer to the internal buffer of the local <code>std::string<\/code> object in <code>name()<\/code> to <code>fopen<\/code>. This object ceases to exist at the end of <code>name()<\/code>, and thus the pointer does not point to valid memory anymore.<\/p>\n<p>Note that you also have a memory leak in your <code>add<\/code> methods: You <code>new<\/code> up <code>std::string<\/code> objects that never get deleted.<\/p>\n<\/p><\/div>\n<div class=\"mt24\"><\/div>\n<\/div>\n<p>            <span class=\"d-none\" itemprop=\"commentCount\">2<\/span> <\/p><\/div>\n<\/div>\n<p>[ad_2]<\/p>\n<p>solved Valgrind getting strange error <\/p>\n","protected":false},"excerpt":{"rendered":"<p>[ad_1] First of all and most importantly: This is not good C++ code, not even decent. For example, some of your #includes are wrong, like &lt;stdio.h&gt; should be &lt;cstdio&gt; instead. The worst thing here are those #defines that make your code utterly unreadable. You really should read a good book on C++! For better readability &#8230; <a title=\"[Solved] Valgrind getting strange error\" class=\"read-more\" href=\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\" aria-label=\"More on [Solved] Valgrind getting strange error\">Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324,913],"class_list":["post-30688","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c","tag-valgrind"],"yoast_head":"<!-- This site is optimized with the Yoast SEO plugin v26.5 - https:\/\/yoast.com\/wordpress\/plugins\/seo\/ -->\n<title>[Solved] Valgrind getting strange error - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] Valgrind getting strange error - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] First of all and most importantly: This is not good C++ code, not even decent. For example, some of your #includes are wrong, like &lt;stdio.h&gt; should be &lt;cstdio&gt; instead. The worst thing here are those #defines that make your code utterly unreadable. You really should read a good book on C++! For better readability ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2023-01-16T06:31:43+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"2 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] Valgrind getting strange error\",\"datePublished\":\"2023-01-16T06:31:43+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\"},\"wordCount\":142,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"c++\",\"valgrind\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\",\"name\":\"[Solved] Valgrind getting strange error - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2023-01-16T06:31:43+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] Valgrind getting strange error\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] Valgrind getting strange error - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] Valgrind getting strange error - JassWeb","og_description":"[ad_1] First of all and most importantly: This is not good C++ code, not even decent. For example, some of your #includes are wrong, like &lt;stdio.h&gt; should be &lt;cstdio&gt; instead. The worst thing here are those #defines that make your code utterly unreadable. You really should read a good book on C++! For better readability ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/","og_site_name":"JassWeb","article_published_time":"2023-01-16T06:31:43+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"2 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] Valgrind getting strange error","datePublished":"2023-01-16T06:31:43+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/"},"wordCount":142,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++","valgrind"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/","url":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/","name":"[Solved] Valgrind getting strange error - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2023-01-16T06:31:43+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-valgrind-getting-strange-error\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] Valgrind getting strange error"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1776403586","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/30688","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=30688"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/30688\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=30688"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=30688"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=30688"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}