{"id":28552,"date":"2022-12-31T23:46:50","date_gmt":"2022-12-31T18:16:50","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/"},"modified":"2022-12-31T23:46:50","modified_gmt":"2022-12-31T18:16:50","slug":"solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/","title":{"rendered":"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated"},"content":{"rendered":"

[ad_1]
\n<\/p>\n

\n
\n
<\/div>\n
\n
\n

strcat()<\/a> (which is a “less-safe” version of strcat_s()) requires both strings to be null-terminated. That’s because strcat() appends its second parameter (source<\/code>) where first parameter (dest<\/code>) ends. It replaces null-terminator of dest with first character of source, appends rest of source<\/code> and then<\/p>\n

\n

a null-character is included at the end of the new string formed by
\n the concatenation of both<\/p>\n<\/blockquote>\n

I would simply change<\/p>\n

strcpy_s(TeamList[0], Team1);\nstrcat_s(TeamList[1], Team2);\nstrcat_s(TeamList[2], Team3);\nstrcat_s(TeamList[3], Team4);\nstrcat_s(TeamList[4], Team5);\n<\/code><\/pre>\n
to<\/p>\n
strcpy_s(TeamList[0], Team1);\nstrcpy_s(TeamList[1], Team2);\nstrcpy_s(TeamList[2], Team3);\nstrcpy_s(TeamList[3], Team4);\nstrcpy_s(TeamList[4], Team5);\n<\/code><\/pre>\n
strcpy_s()<\/code> does not have any requirements regarding contents of destination – only its capacity matters.<\/p>\n
If you want to stick with strcat_s()<\/code>, do this:<\/p>\n
char TeamList[5][7];\nmemset(TeamList, 0, sizeof(char) * 5 * 7);\n<\/code><\/pre>\n
Then, this line:<\/p>\n
TeamList[5][7]= '\\0';\n<\/code><\/pre>\n
is not required, It is incorrect anyway, because for N-element array valid indexes are [0; N-1].<\/p>\n
EDIT<\/strong><\/p>\n
Since in your case swapping comes into play, I would suggest you totally different approach.<\/p>\n
First of all:<\/p>\n
#include <string>\n<\/code><\/pre>\n
Then, initialize teams this way:<\/p>\n
std::string TeamList[] =\n{\n  \"Grubs\",\n  \"Giants\",\n  \"Bulls\",\n  \"Snakes\",\n  \"Echos\"\n};\n<\/code><\/pre>\n
Now, TeamList<\/code> is an array containing 5 elements and each of these elements is an object of type std::string, containing name of a particular team.<\/p>\n
Now, if you want to swap, let’s say, teams 1 and 3:<\/p>\n
std::swap(TeamList[1], TeamList[3]);\n<\/code><\/pre>\n
std::swap()<\/code> is a standard C++ function extensively used in standard library implementation. It is overloaded for many standard types, including std::string<\/code>. This solution has one, critical benefit: if string’s content is held on the heap, swapping two strings is as simple as swapping pointers (and some length\/capacity variables).<\/p>\n
Oh, and one more thing: if you are not familiar with std::string<\/code> and you would need to get pointer to a buffer containing string’s data, you can do it this way:<\/p>\n
const char* team_1_raw_name = TeamList[0].c_str();\n<\/code><\/pre>\n
See this page for more info about std::string<\/a><\/p>\n<\/p><\/div>\n
<\/div>\n<\/div>\n
            7<\/span> <\/p><\/div>\n<\/div>\n
[ad_2]<\/p>\n
solved C++ copying char to a char array (Debug assertion failed) says string is not null terminated <\/p>\n","protected":false},"excerpt":{"rendered":"
[ad_1] strcat() (which is a “less-safe” version of strcat_s()) requires both strings to be null-terminated. That’s because strcat() appends its second parameter (source) where first parameter (dest) ends. It replaces null-terminator of dest with first character of source, appends rest of source and then a null-character is included at the end of the new string … Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324],"class_list":["post-28552","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c"],"yoast_head":"\n[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] strcat() (which is a “less-safe” version of strcat_s()) requires both strings to be null-terminated. That’s because strcat() appends its second parameter (source) where first parameter (dest) ends. It replaces null-terminator of dest with first character of source, appends rest of source and then a null-character is included at the end of the new string ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2022-12-31T18:16:50+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"2 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated\",\"datePublished\":\"2022-12-31T18:16:50+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/\"},\"wordCount\":287,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"c++\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/\",\"name\":\"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2022-12-31T18:16:50+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775193939\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775193939\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated - JassWeb","og_description":"[ad_1] strcat() (which is a “less-safe” version of strcat_s()) requires both strings to be null-terminated. That’s because strcat() appends its second parameter (source) where first parameter (dest) ends. It replaces null-terminator of dest with first character of source, appends rest of source and then a null-character is included at the end of the new string ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/","og_site_name":"JassWeb","article_published_time":"2022-12-31T18:16:50+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"2 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated","datePublished":"2022-12-31T18:16:50+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/"},"wordCount":287,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/","url":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/","name":"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2022-12-31T18:16:50+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-c-copying-char-to-a-char-array-debug-assertion-failed-says-string-is-not-null-terminated\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] C++ copying char to a char array (Debug assertion failed) says string is not null terminated"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775193939","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775193939","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/28552","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=28552"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/28552\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=28552"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=28552"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=28552"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}