{"id":23000,"date":"2022-11-23T02:12:22","date_gmt":"2022-11-22T20:42:22","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/"},"modified":"2022-11-23T02:12:22","modified_gmt":"2022-11-22T20:42:22","slug":"solved-what-is-wrong-with-my-code-c-language-closed","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/","title":{"rendered":"[Solved] What is wrong with my code? C language [closed]"},"content":{"rendered":"<p> [ad_1]<br \/>\n<\/p>\n<div id=\"answer-34472760\" class=\"answer js-answer accepted-answer js-accepted-answer\" data-answerid=\"34472760\" data-parentid=\"34472119\" data-score=\"0\" data-position-on-page=\"1\" data-highest-scored=\"1\" data-question-has-accepted-highest-score=\"1\" itemprop=\"acceptedAnswer\" itemscope itemtype=\"https:\/\/schema.org\/Answer\">\n<div class=\"post-layout\">\n<div class=\"votecell post-layout--left\"><\/div>\n<div class=\"answercell post-layout--right\">\n<div class=\"s-prose js-post-body\" itemprop=\"text\">\n<p>There are several errors in your code, for example strings that are too short, use of <code>feof()<\/code> and trying to use <code>fgets()<\/code> several times on the same text line in the file. While possible, it&#8217;s not very clean, so I&#8217;ve use <code>strtok()<\/code> after reading a whole text line.<\/p>\n<p>In this re-written code I have also detected when the month changes. I&#8217;ve used pointers to the data within the line. Please note that if you want to store the extracted data into arrays, you&#8217;ll have to make such arrays and copy the data, because the data is overwritten on every line.<\/p>\n<pre><code>#include &lt;stdio.h&gt;\n#include &lt;string.h&gt;\n#include &lt;stdlib.h&gt;\n\nint main(int argc, const char * argv[])\n{\n    FILE *fr;\n    char line[42];\n    char *date, *pack, *method;\n    int year, month, day, lastmonth = -1;\n\n    if((fr = fopen(\"input.txt\",\"r\")) == NULL)\n        exit(1);\n\n    while(fgets(line, sizeof line, fr) != NULL) {   \/\/ instead of feof()\n\n        pack = method = NULL;                       \/\/ preset to test later\n        date = strtok(line, \" \\r\\n\\t\");             \/\/ strip newline too\n        if(date &amp;&amp; strlen(date) == 10) {            \/\/ check valid substring\n            year  = atoi(date);\n            month = atoi(date+5);\n            day   = atoi(date+8);\n            printf(\"%04d-%02d-%02d\", year, month, day);\n            pack  = strtok(NULL, \" \\r\\n\\t\");\n            if(pack) {                              \/\/ was substring extracted?\n                method  = strtok(NULL, \" \\r\\n\\t\");\n            }\n            if (pack &amp;&amp; method) {                   \/\/ were substrings extracted?\n                printf(\" %s %s\", pack, method);\n                if (month != lastmonth &amp;&amp; lastmonth &gt;= 0)\n                    printf(\" *New month*\");\n                }\n            else {\n                printf(\" *Ignored*\");\n            }\n            lastmonth = month;\n            printf(\"\\n\");\n        }\n        else {\n            printf(\"*Invalid line*\\n\");\n        }\n    }\n\n    fclose(fr);\n    return 0;\n}\n<\/code><\/pre>\n<p>Program output:<\/p>\n<pre><code>2015-05-01 A GG\n2015-05-02 H GG\n2015-05-03 H AA\n2015-05-05 G SS\n2015-05-06 D GG\n2015-05-17 V GG\n2015-05-24 *Ignored*\n2015-05-29 V GG\n2015-06-01 V GG *New month*\n<\/code><\/pre>\n<\/p><\/div>\n<div class=\"mt24\"><\/div>\n<\/div>\n<p>            <span class=\"d-none\" itemprop=\"commentCount\">1<\/span> <\/p><\/div>\n<\/div>\n<p>[ad_2]<\/p>\n<p>solved What is wrong with my code? C language [closed] <\/p>\n","protected":false},"excerpt":{"rendered":"<p>[ad_1] There are several errors in your code, for example strings that are too short, use of feof() and trying to use fgets() several times on the same text line in the file. While possible, it&#8217;s not very clean, so I&#8217;ve use strtok() after reading a whole text line. In this re-written code I have &#8230; <a title=\"[Solved] What is wrong with my code? C language [closed]\" class=\"read-more\" href=\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\" aria-label=\"More on [Solved] What is wrong with my code? C language [closed]\">Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324],"class_list":["post-23000","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c"],"yoast_head":"<!-- This site is optimized with the Yoast SEO plugin v26.5 - https:\/\/yoast.com\/wordpress\/plugins\/seo\/ -->\n<title>[Solved] What is wrong with my code? C language [closed] - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] What is wrong with my code? C language [closed] - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] There are several errors in your code, for example strings that are too short, use of feof() and trying to use fgets() several times on the same text line in the file. While possible, it&#8217;s not very clean, so I&#8217;ve use strtok() after reading a whole text line. In this re-written code I have ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2022-11-22T20:42:22+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"2 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] What is wrong with my code? C language [closed]\",\"datePublished\":\"2022-11-22T20:42:22+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\"},\"wordCount\":125,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"c++\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\",\"name\":\"[Solved] What is wrong with my code? C language [closed] - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2022-11-22T20:42:22+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] What is wrong with my code? C language [closed]\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] What is wrong with my code? C language [closed] - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] What is wrong with my code? C language [closed] - JassWeb","og_description":"[ad_1] There are several errors in your code, for example strings that are too short, use of feof() and trying to use fgets() several times on the same text line in the file. While possible, it&#8217;s not very clean, so I&#8217;ve use strtok() after reading a whole text line. In this re-written code I have ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/","og_site_name":"JassWeb","article_published_time":"2022-11-22T20:42:22+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"2 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] What is wrong with my code? C language [closed]","datePublished":"2022-11-22T20:42:22+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/"},"wordCount":125,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/","url":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/","name":"[Solved] What is wrong with my code? C language [closed] - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2022-11-22T20:42:22+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-what-is-wrong-with-my-code-c-language-closed\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] What is wrong with my code? C language [closed]"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/23000","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=23000"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/23000\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=23000"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=23000"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=23000"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}