{"id":19855,"date":"2022-11-07T22:53:27","date_gmt":"2022-11-07T17:23:27","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/"},"modified":"2022-11-07T22:53:27","modified_gmt":"2022-11-07T17:23:27","slug":"solved-can-not-account-for-an-extra-line-in-output","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/","title":{"rendered":"[Solved] Can not account for an extra line in output"},"content":{"rendered":"<p> [ad_1]<br \/>\n<\/p>\n<div id=\"answer-44992837\" class=\"answer js-answer accepted-answer js-accepted-answer\" data-answerid=\"44992837\" data-parentid=\"44990796\" data-score=\"0\" data-position-on-page=\"1\" data-highest-scored=\"1\" data-question-has-accepted-highest-score=\"1\" itemprop=\"acceptedAnswer\" itemscope itemtype=\"https:\/\/schema.org\/Answer\">\n<div class=\"post-layout\">\n<div class=\"votecell post-layout--left\"><\/div>\n<div class=\"answercell post-layout--right\">\n<div class=\"s-prose js-post-body\" itemprop=\"text\">\n<p>Okay so, I don&#8217;t really think there is any error, but I will propose you a modified version of your code, which will be more readable, more efficient, and less error prone:<\/p>\n<pre><code>\/\/ #include&lt;bits\/stdc++.h&gt; I don't know what that include is, use more specific header based on your needs like\n#include &lt;string&gt; \/\/ for std::string\n#include &lt;iostream&gt; \/\/ for std::cout\n\n\/\/ using namespace std;\n\/\/ Avoid using \"using namespace\", it's a really bad practice in C++\n\nint main()\n{\n  std::string name;\n  std::string sname;\n  int t;\n\n  std::cin &gt;&gt; t;\n\n  while(t--)\n    {\n      std::getline(std::cin, name);\n\n      \/\/ *(name.begin()) -= 32;\n      \/\/ Use operator[], it was made for that purpose\n      name[0] -= 32;\n\n      size_t pos = name.find(\" \");\n\n      if(pos == std::string::npos)\n        {\n          std::cout &lt;&lt; name;\n        }\n\n      name[pos] = 49; \/\/ pretty dangerous since pos could be std::string::npos, which is the max value for a size_t\n\n      pos = name.find(\" \");\n\n      size_t first_one = name.find(\"1\");\n\n      \/\/ here you should check if first_one != std::string::npos\n\n      if(pos == std::string::npos)\n        {\n          name[first_one + 1] -= 32;\n          sname = name.substr(name.find(\"1\") + 1); \/\/ dangerous\n          std::cout &lt;&lt; name[0] &lt;&lt; \". \" &lt;&lt; sname;\n        }\n        else\n        {\n          name[first_one + 1] -= 32;\n          name[pos + 1] -= 32;\n          sname = name.substr(name.find(\" \")+1); \/\/ dangerous too\n          std::cout &lt;&lt; name[0] &lt;&lt; \". \" &lt;&lt; name[name.find(\"1\")+1] &lt;&lt; \". \" &lt;&lt; sname;\n        }\n      \/\/ printf(\"\\n\"); Avoid using printf, std::cout is here for c++ (printf comes from C)\n      std::cout &lt;&lt; '\\n';\n    }\n  return 0;\n}\n<\/code><\/pre>\n<p>So to conclude, avoid &#8220;using namespace&#8221;, that&#8217;s bad, for explanation, google, first link, etc..<br \/>\nUse websites like cppreference.com or cplusplus.com to see methods and usages of objects like std::string or std::cout.<br \/>\nAvoid doing <code>std::cout &lt;&lt; \"a\" &lt;&lt; \"b\";<\/code>, instead do <code>std::cout &lt;&lt; \"ab\";<\/code>, or if you need to output single chars, <code>std::cout &lt;&lt; 'a';<\/code>.<\/p>\n<p>Verify everything, a big and very important rule for devs is &#8220;Never trust the user&#8221;, always imagine they are gonna try to break your program, you might think &#8220;yeah but i will be the only user&#8221;, that&#8217;s a bad reason, take good habits early. So always check, here if t is negative, your program will be almost infinite, if there is no space or &#8216;1&#8217;, it will explode, etc.. All of these small mistakes might be security flaws in bigger software.<\/p>\n<p>Good luck \ud83d\ude42<\/p>\n<\/p><\/div>\n<div class=\"mt24\"><\/div>\n<\/div>\n<p>            <span class=\"d-none\" itemprop=\"commentCount\">2<\/span> <\/p><\/div>\n<\/div>\n<p>[ad_2]<\/p>\n<p>solved Can not account for an extra line in output <\/p>\n","protected":false},"excerpt":{"rendered":"<p>[ad_1] Okay so, I don&#8217;t really think there is any error, but I will propose you a modified version of your code, which will be more readable, more efficient, and less error prone: \/\/ #include&lt;bits\/stdc++.h&gt; I don&#8217;t know what that include is, use more specific header based on your needs like #include &lt;string&gt; \/\/ for &#8230; <a title=\"[Solved] Can not account for an extra line in output\" class=\"read-more\" href=\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\" aria-label=\"More on [Solved] Can not account for an extra line in output\">Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324,362],"class_list":["post-19855","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c","tag-string"],"yoast_head":"<!-- This site is optimized with the Yoast SEO plugin v26.5 - https:\/\/yoast.com\/wordpress\/plugins\/seo\/ -->\n<title>[Solved] Can not account for an extra line in output - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] Can not account for an extra line in output - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] Okay so, I don&#8217;t really think there is any error, but I will propose you a modified version of your code, which will be more readable, more efficient, and less error prone: \/\/ #include&lt;bits\/stdc++.h&gt; I don&#039;t know what that include is, use more specific header based on your needs like #include &lt;string&gt; \/\/ for ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2022-11-07T17:23:27+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"2 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] Can not account for an extra line in output\",\"datePublished\":\"2022-11-07T17:23:27+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\"},\"wordCount\":186,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"c++\",\"string\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\",\"name\":\"[Solved] Can not account for an extra line in output - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2022-11-07T17:23:27+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] Can not account for an extra line in output\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] Can not account for an extra line in output - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] Can not account for an extra line in output - JassWeb","og_description":"[ad_1] Okay so, I don&#8217;t really think there is any error, but I will propose you a modified version of your code, which will be more readable, more efficient, and less error prone: \/\/ #include&lt;bits\/stdc++.h&gt; I don't know what that include is, use more specific header based on your needs like #include &lt;string&gt; \/\/ for ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/","og_site_name":"JassWeb","article_published_time":"2022-11-07T17:23:27+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"2 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] Can not account for an extra line in output","datePublished":"2022-11-07T17:23:27+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/"},"wordCount":186,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++","string"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/","url":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/","name":"[Solved] Can not account for an extra line in output - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2022-11-07T17:23:27+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-can-not-account-for-an-extra-line-in-output\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] Can not account for an extra line in output"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/19855","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=19855"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/19855\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=19855"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=19855"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=19855"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}