{"id":13276,"date":"2022-10-03T14:52:25","date_gmt":"2022-10-03T09:22:25","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/"},"modified":"2022-10-03T14:52:25","modified_gmt":"2022-10-03T09:22:25","slug":"solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/","title":{"rendered":"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don’t create a new binary tree [closed]"},"content":{"rendered":"

[ad_1]
\n<\/p>\n

\n
\n
<\/div>\n
\n
\n

It is a nuisance when we have to create an MCVE from fragments of a program. However, it’s doable \u2014 it’s a pain, but doable.<\/p>\n

Here’s my variation on your code. Of the 115 lines shown, 35 are what you wrote in the question \u2014 roughly. So, I had to create twice as much code to create a semi-plausible MCVE.<\/p>\n

#include <assert.h>\n#include <stdio.h>\n#include <stdlib.h>\n\ntypedef struct ABin_s *ABin;\nstruct ABin_s\n{\n    int valor;\n    ABin esq;\n    ABin dir;\n};\n\nABin somasAcA_OK(ABin a);\nint getsums(ABin a);\nABin somasAcA(ABin a);\n\nstatic ABin newABin(int valor, ABin esq, ABin dir)\n{\n    ABin ab = malloc(sizeof(*ab));\n    if (ab == 0)\n    {\n        fprintf(stderr, \"Failed to malloc %zu bytes\\n\", sizeof(*ab));\n        exit(EXIT_FAILURE);\n    }\n    ab->valor = valor;\n    ab->esq = esq;\n    ab->dir = dir;\n    return ab;\n}\n\nint getsums(ABin a)\n{\n    if (a == NULL)\n        return 0;\n    int esq = getsums(a->esq);\n    int dir = getsums(a->dir);\n    return(a->valor + esq + dir);\n}\n\nABin somasAcA_OK(ABin a)\n{\n    ABin b, *res;\n    res = &b;\n\n    if (a != NULL)\n    {\n        b = newABin(getsums(a), NULL, NULL);\n        b->esq = somasAcA_OK(a->esq);\n        b->dir = somasAcA_OK(a->dir);\n    }\n    if (a == NULL)\n        b = NULL;\n    return *res;\n}\n\nABin somasAcA(ABin a)\n{   \/\/ Remove unused b\n    if (a != NULL)\n    {\n        a->valor = getsums(a);\n        a->esq = somasAcA(a->esq);\n        a->dir = somasAcA(a->dir);\n    }\n    return a;\n}\n\nstatic void print_postorder(ABin node)\n{\n    if (node != 0)\n    {\n        print_postorder(node->esq);\n        print_postorder(node->dir);\n        printf(\"Valor = %d\\n\", node->valor);\n    }\n}\n\nstatic void print_tree(const char *tag, ABin node)\n{\n    printf(\"Tree: %s\\n\", tag);\n    print_postorder(node);\n}\n\nstatic void free_tree(ABin node)\n{\n    if (node != 0)\n    {\n        free_tree(node->esq);\n        free_tree(node->dir);\n        free(node);\n    }\n}\n\nint main(void)\n{\n    ABin root = newABin(3, 0, 0);\n    ABin esq = newABin(1, 0, 0);\n    ABin dir = newABin(2, 0, 0);\n    root->esq = esq;\n    root->dir = dir;\n\n    print_tree(\"Before\", root);\n\n    ABin eval = somasAcA(root);\n    assert(eval == root);\n\n    print_tree(\"After\", root);\n\n    eval = somasAcA_OK(root);\n    assert(eval != root);\n\n    print_tree(\"Second time\", root);\n\n    free(root);\n    free(esq);\n    free(dir);\n    free_tree(eval);\n}\n<\/code><\/pre>\n
I created somasAcA_OK()<\/code> from your working function, marginally cleaning it up.  My somasAcA()<\/code> is your ‘non-working’ function, somewhat cleaned up.  I don’t think I significantly changed the functionality of either.  Note that the tree building code doesn’t attempt to use a function to build it \u2014 you’ve not shown such a function.  It creates three nodes and links them manually.<\/p>\n
The code compiles cleanly under GCC 6.1.0 on Mac OS X 10.11.5 with the command line:<\/p>\n
$ gcc -O3 -g -std=c11 -Wall -Wextra -Wmissing-prototypes -Wstrict-prototypes \\\n>     -Wold-style-definition -Werror abin.c -o abin\n$\n<\/code><\/pre>\n
When run under valgrind<\/code><\/a>, it gets a clean bill of health.<\/p>\n
$ .\/abin\nTree: Before\nValor = 1\nValor = 2\nValor = 3\nTree: After\nValor = 1\nValor = 2\nValor = 6\nTree: Second time\nValor = 1\nValor = 2\nValor = 6\n$\n<\/code><\/pre>\n
On the basis of what I see, your second lot of code, the one that you claim fails, works correctly, but the one that you claim succeeds doesn’t actually do the addition (the last valor<\/code> should be 9<\/code> on the second time).<\/p>\n
I’m a bit dubious about the way your functions work.  I’d expect the somasAcA()<\/code> to be evaluating the sub-trees before summing the modified trees.  That it works could be a side-effect of the minimal tree.  Maybe you should be using:<\/p>\n
ABin somasAcA(ABin a)\n{\n    if (a != NULL)\n    {\n        a->esq = somasAcA(a->esq);\n        a->dir = somasAcA(a->dir);\n        a->valor = getsums(a);\n    }\n    return a;\n}\n<\/code><\/pre>\n
I’m not convinced that it needs to return a value, either, so with some collateral changes, you could use:<\/p>\n
void somasAcA(ABin a)\n{\n    if (a != NULL)\n    {\n        somasAcA(a->esq);\n        somasAcA(a->dir);\n        a->valor = getsums(a);\n    }\n}\n<\/code><\/pre>\n
Extending the testing to more extensive trees is left as an exercise for someone with the correct tree-creation function code.<\/p>\n<\/p><\/div>\n
<\/div>\n<\/div>\n
            <\/span> <\/p><\/div>\n<\/div>\n
[ad_2]<\/p>\n
solved Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don’t create a new binary tree [closed] <\/p>\n","protected":false},"excerpt":{"rendered":"
[ad_1] It is a nuisance when we have to create an MCVE from fragments of a program. However, it’s doable \u2014 it’s a pain, but doable. Here’s my variation on your code. Of the 115 lines shown, 35 are what you wrote in the question \u2014 roughly. So, I had to create twice as much … Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[2566,324,1187,1381],"class_list":["post-13276","post","type-post","status-publish","format-standard","hentry","category-solved","tag-binary-tree","tag-c","tag-segmentation-fault","tag-tree"],"yoast_head":"\n[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don't create a new binary tree [closed] - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don't create a new binary tree [closed] - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] It is a nuisance when we have to create an MCVE from fragments of a program. However, it’s doable \u2014 it’s a pain, but doable. Here’s my variation on your code. Of the 115 lines shown, 35 are what you wrote in the question \u2014 roughly. So, I had to create twice as much ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2022-10-03T09:22:25+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"3 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don’t create a new binary tree [closed]\",\"datePublished\":\"2022-10-03T09:22:25+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/\"},\"wordCount\":323,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"binary-tree\",\"c++\",\"segmentation-fault\",\"tree\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/\",\"name\":\"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don't create a new binary tree [closed] - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2022-10-03T09:22:25+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don’t create a new binary tree [closed]\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don't create a new binary tree [closed] - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don't create a new binary tree [closed] - JassWeb","og_description":"[ad_1] It is a nuisance when we have to create an MCVE from fragments of a program. However, it’s doable \u2014 it’s a pain, but doable. Here’s my variation on your code. Of the 115 lines shown, 35 are what you wrote in the question \u2014 roughly. So, I had to create twice as much ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/","og_site_name":"JassWeb","article_published_time":"2022-10-03T09:22:25+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"3 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don’t create a new binary tree [closed]","datePublished":"2022-10-03T09:22:25+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/"},"wordCount":323,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["binary-tree","c++","segmentation-fault","tree"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/","url":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/","name":"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don't create a new binary tree [closed] - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2022-10-03T09:22:25+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-function-to-turn-a-binary-tree-into-the-sums-of-all-nodes-below-each-node-segmentation-fault-if-i-dont-create-a-new-binary-tree-closed\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] Function to turn a Binary Tree into the sums of all nodes below each node; segmentation fault if I don’t create a new binary tree [closed]"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/13276","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=13276"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/13276\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=13276"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=13276"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=13276"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}