{"id":13009,"date":"2022-10-02T18:10:59","date_gmt":"2022-10-02T12:40:59","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/"},"modified":"2022-10-02T18:10:59","modified_gmt":"2022-10-02T12:40:59","slug":"solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/","title":{"rendered":"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows?"},"content":{"rendered":"

[ad_1]
\n<\/p>\n

\n
\n
<\/div>\n
\n
\n

I’m amazed this program works. There are sections of code that I don’t understand, for example: <\/p>\n

STARTB:for (i = 0; i < ns; i++) {\n    if (numholder[i] == \"(\") {\n        temp_i = i;\n        i2 = i;\n    }\n    if (numholder[i] == \")\") {\n        temp_i = i - temp_i;\n    }\n}\n<\/code><\/pre>\n
The variables temp_i<\/code> and i2<\/code> may be overwritten before the loop ends.
\nAn example expression: (6 + (4 * 5)) * 2
\nIf the numholder<\/code> contains more than one open parenthesis.  <\/p>\n
More items from inspection:  <\/p>\n
if\/else\/if ladders difficult to read<\/strong>
\nIn your program, you could make the code easier to read (in my opinion) by using the switch<\/code> and case<\/code> statements:  <\/p>\n
  switch (c)\n  {\n    case '0':\n    case '1':\n    case '2':\n    case '3':\n    case '4':\n    case '5':\n    case '6':\n    case '7':\n    case '8':\n    case '9':\n        \/\/ c is a number\n        num += c;\n        break;\n    case '*':\n    case \"https:\/\/stackoverflow.com\/\":\n    case '+':\n    case '-':\n      \/\/ c is an operator\n      numholder.push_back(num);\n      std::string s(c);  \/\/ Simplified all nested if statements.\n      numholder.push_back(s);\n      break;\n    \/\/ And so on.\n<\/code><\/pre>\n
Repetitive code fragments<\/strong>
\nWhy are you copying multiple code fragments instead of using variables:  <\/p>\n
ans = to_string(stof(temp_numholder[temp_n_size-i-2]) \/ stof(temp_numholder[temp_n_size-i]));\n<\/code><\/pre>\n
Looks like you could create two variables of type double<\/code> before you start evaluating the expression:  <\/p>\n
  double argument1 = 0.0;\n  double argument2 = 0.0;\n  argument1 = stof(temp_numholder[temp_n_size-i-2]);\n  argument2 = stof(temp_numholder[temp_n_size-i]);\n  switch (operator)\n  {\n    case '*':\n      ans = to_string(argument1 * argument2);\n      break;\n    case \"https:\/\/stackoverflow.com\/\":\n      ans = to_string(argument1 * argument2);\n      break;\n    case '+':\n      ans = to_string(argument1 * argument2);\n      break;\n    case '-':\n      ans = to_string(argument1 * argument2);\n      break;\n  }\n<\/code><\/pre>\n
Use appropriate data structures<\/strong>
\nYour program evaluates the expression the way I demonstrate math to elementary students: by erasing the complex expression and inserting the simplified and restarting the parsing \/ evaluation process.  Very, very slow.  Computers can do this much faster by using other data structures, such as stacks<\/em> and trees<\/em>.  <\/p>\n
Search StackOverflow and the web for “c++ expression evaluate” and hopefully there will be some simple and correct examples.<\/p>\n<\/p><\/div>\n
<\/div>\n<\/div>\n
            <\/span> <\/p><\/div>\n<\/div>\n
[ad_2]<\/p>\n
solved Why does my Mathematical Expression Evaluation function not work on Windows? <\/p>\n","protected":false},"excerpt":{"rendered":"
[ad_1] I’m amazed this program works. There are sections of code that I don’t understand, for example: STARTB:for (i = 0; i < ns; i++) { if (numholder[i] == “(“) { temp_i = i; i2 = i; } if (numholder[i] == “)”) { temp_i = i – temp_i; } } The variables temp_i and i2 … Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324,2082,413,876,774],"class_list":["post-13009","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c","tag-expression","tag-function","tag-macos","tag-windows"],"yoast_head":"\n[Solved] Why does my Mathematical Expression Evaluation function not work on Windows? - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows? - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] I’m amazed this program works. There are sections of code that I don’t understand, for example: STARTB:for (i = 0; i < ns; i++) { if (numholder[i] == "(") { temp_i = i; i2 = i; } if (numholder[i] == ")") { temp_i = i - temp_i; } } The variables temp_i and i2 ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2022-10-02T12:40:59+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"2 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows?\",\"datePublished\":\"2022-10-02T12:40:59+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/\"},\"wordCount\":194,\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"keywords\":[\"c++\",\"expression\",\"function\",\"macos\",\"windows\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/\",\"url\":\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/\",\"name\":\"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows? - JassWeb\",\"isPartOf\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#website\"},\"datePublished\":\"2022-10-02T12:40:59+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\/\/jassweb.com\/solved\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows?\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/jassweb.com\/solved\/#website\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\/\/jassweb.com\/solved\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\/\/jassweb.com\/solved\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\/\/jassweb.com\/solved\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\",\"url\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"contentUrl\":\"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/\",\"url\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"contentUrl\":\"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\/\/jassweb.com\"],\"url\":\"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows? - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows? - JassWeb","og_description":"[ad_1] I’m amazed this program works. There are sections of code that I don’t understand, for example: STARTB:for (i = 0; i < ns; i++) { if (numholder[i] == \"(\") { temp_i = i; i2 = i; } if (numholder[i] == \")\") { temp_i = i - temp_i; } } The variables temp_i and i2 ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/","og_site_name":"JassWeb","article_published_time":"2022-10-02T12:40:59+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"2 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows?","datePublished":"2022-10-02T12:40:59+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/"},"wordCount":194,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++","expression","function","macos","windows"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/","url":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/","name":"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows? - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2022-10-02T12:40:59+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-why-does-my-mathematical-expression-evaluation-function-not-work-on-windows\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] Why does my Mathematical Expression Evaluation function not work on Windows?"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/image\/","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1775798750","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/13009","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=13009"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/13009\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=13009"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=13009"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=13009"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}