{"id":10044,"date":"2022-09-22T00:38:52","date_gmt":"2022-09-21T19:08:52","guid":{"rendered":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/"},"modified":"2022-09-22T00:38:52","modified_gmt":"2022-09-21T19:08:52","slug":"solved-programming-task-ask-closed","status":"publish","type":"post","link":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/","title":{"rendered":"[Solved] programming task ask [closed]"},"content":{"rendered":"

[ad_1]
\n<\/p>\n

\n
\n
<\/div>\n
\n
\n

There are a few issues here:<\/p>\n

    \n
  1. \n

    Your program fails to compile because of the misplaced semi-colon in <\/p>\n

    cout<<\"\\nNew String 2 is :\";<<b\n<\/code><\/pre>\n<\/li>\n
  2. \n
    Your program crashes at strcpy(a,x);<\/code> because you’re copying into a<\/code> which is uninitialised – it has no memory allocated.  You’d need to call new<\/code> on a<\/code> for this to work, which would also mean you’d need to know the size of the array required (another parameter for the function probably).<\/p>\n<\/li>\n
  3. \n
    Using std::string<\/code> and std::wstring<\/code> is almost always preferable to dealing with raw char arrays. See this question for example.  I see you’d probably already considered it since you’ve got #include <string><\/code><\/p>\n<\/li>\n
  4. \n
    Since you’re required to perform identical operations on differing types, I suspect the point of the exercise might have been to use templates.<\/p>\n<\/li>\n
  5. \n
    You said<\/p>\n
    \n
    getNiCount<\/code> should return the number of occurrences…<\/p>\n<\/blockquote>\n
    yet your getNiCount<\/code> doesn’t return anything.<\/p>\n<\/li>\n
  6. \n
    using namespace std;<\/code> is often considered bad practice.<\/p>\n<\/li>\n
  7. \n
    It’s generally worth favouring pre-increments rather than post-increments, although in this particular case, there’s no overhead.<\/p>\n<\/li>\n<\/ol>\n
    \n
    To give you an example including the recommendations above:<\/p>\n
    #include <iostream>\n#include <string>\n\ntemplate<typename StrType>\nclass MyClass {\n public:\n  int getNiCount(const StrType& input) const;\n  void replaceNiWithNI(StrType& input) const;\n};\n\ntemplate<typename StrType>\nint MyClass<StrType>::getNiCount(const StrType& input) const {\n  int count = 0;\n  for (int i = 0; i < input.size() - 1; ++i) {\n    if (input[i] == 'N' && input[i + 1] == 'i')\n      ++count;\n  }\n  return count;\n}\n\ntemplate<typename StrType>\nvoid MyClass<StrType>::replaceNiWithNI(StrType& input) const {\n  for (int i = 0; i < input.size() - 1; ++i) {\n    if (input[i] == 'N' && input[i + 1] == 'i')\n      input[i + 1] = 'I';\n  }\n}\n\n\nint main() {\n  const char* szTestString1 = \"Ni nI NI nI Ni\";\n  MyClass<std::string> ob1;\n  std::string testString1(szTestString1);\n  int count1 = ob1.getNiCount(testString1);\n  ob1.replaceNiWithNI(testString1);\n  std::cout << \"Found \" << count1 << \" occurences of Ni in String 1.  \"\n            << \"New string: \" << testString1 << '\\n';\n\n  const wchar_t* szTestString2 = L\"Ni nI NI nI Ni\";\n  MyClass<std::wstring> ob2;\n  std::wstring testString2(szTestString2);\n  int count2 = ob2.getNiCount(testString2);\n  ob2.replaceNiWithNI(testString2);\n  std::wcout << L\"Found \" << count2 << L\" occurences of Ni in String 2.  \"\n             << L\"New string: \" << testString2 << '\\n';\n\n  getchar();\n  return 0;\n}\n<\/code><\/pre>\n
    I’ve generally left the way you locate and replace the Ni<\/code> chars as you had it.  There are more sophisticated options available in the member functions of std::string<\/code><\/a> and in <algorithm><\/code> library<\/a>.<\/p>\n<\/p><\/div>\n
    <\/div>\n<\/div>\n
                0<\/span> <\/p><\/div>\n<\/div>\n
    [ad_2]<\/p>\n
    solved programming task ask [closed] <\/p>\n","protected":false},"excerpt":{"rendered":"
    [ad_1] There are a few issues here: Your program fails to compile because of the misplaced semi-colon in cout<<“\\nNew String 2 is :”;<<b Your program crashes at strcpy(a,x); because you’re copying into a which is uninitialised – it has no memory allocated. You’d need to call new on a for this to work, which would … Read more<\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[320],"tags":[324],"class_list":["post-10044","post","type-post","status-publish","format-standard","hentry","category-solved","tag-c"],"yoast_head":"\n[Solved] programming task ask [closed] - JassWeb<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"[Solved] programming task ask [closed] - JassWeb\" \/>\n<meta property=\"og:description\" content=\"[ad_1] There are a few issues here: Your program fails to compile because of the misplaced semi-colon in cout<<"nNew String 2 is :";<<b Your program crashes at strcpy(a,x); because you’re copying into a which is uninitialised – it has no memory allocated. You’d need to call new on a for this to work, which would ... Read more\" \/>\n<meta property=\"og:url\" content=\"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/\" \/>\n<meta property=\"og:site_name\" content=\"JassWeb\" \/>\n<meta property=\"article:published_time\" content=\"2022-09-21T19:08:52+00:00\" \/>\n<meta name=\"author\" content=\"Kirat\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Written by\" \/>\n\t<meta name=\"twitter:data1\" content=\"Kirat\" \/>\n\t<meta name=\"twitter:label2\" content=\"Est. reading time\" \/>\n\t<meta name=\"twitter:data2\" content=\"2 minutes\" \/>\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\\\/\\\/schema.org\",\"@graph\":[{\"@type\":\"Article\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/#article\",\"isPartOf\":{\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/\"},\"author\":{\"name\":\"Kirat\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#\\\/schema\\\/person\\\/65c9c7b7958150c0dc8371fa35dd7c31\"},\"headline\":\"[Solved] programming task ask [closed]\",\"datePublished\":\"2022-09-21T19:08:52+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/\"},\"wordCount\":207,\"publisher\":{\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#organization\"},\"keywords\":[\"c++\"],\"articleSection\":[\"Solved\"],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/\",\"url\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/\",\"name\":\"[Solved] programming task ask [closed] - JassWeb\",\"isPartOf\":{\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#website\"},\"datePublished\":\"2022-09-21T19:08:52+00:00\",\"breadcrumb\":{\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/solved-programming-task-ask-closed\\\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"name\":\"Home\",\"item\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/\"},{\"@type\":\"ListItem\",\"position\":2,\"name\":\"[Solved] programming task ask [closed]\"}]},{\"@type\":\"WebSite\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#website\",\"url\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/\",\"name\":\"JassWeb\",\"description\":\"Build High-quality Websites\",\"publisher\":{\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":{\"@type\":\"EntryPoint\",\"urlTemplate\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/?s={search_term_string}\"},\"query-input\":{\"@type\":\"PropertyValueSpecification\",\"valueRequired\":true,\"valueName\":\"search_term_string\"}}],\"inLanguage\":\"en-US\"},{\"@type\":\"Organization\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#organization\",\"name\":\"Jass Web\",\"url\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/\",\"logo\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#\\\/schema\\\/logo\\\/image\\\/\",\"url\":\"https:\\\/\\\/jassweb.com\\\/wp-content\\\/uploads\\\/2021\\\/02\\\/jass-website-logo-1.png\",\"contentUrl\":\"https:\\\/\\\/jassweb.com\\\/wp-content\\\/uploads\\\/2021\\\/02\\\/jass-website-logo-1.png\",\"width\":693,\"height\":132,\"caption\":\"Jass Web\"},\"image\":{\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#\\\/schema\\\/logo\\\/image\\\/\"}},{\"@type\":\"Person\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/#\\\/schema\\\/person\\\/65c9c7b7958150c0dc8371fa35dd7c31\",\"name\":\"Kirat\",\"image\":{\"@type\":\"ImageObject\",\"inLanguage\":\"en-US\",\"@id\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/wp-content\\\/litespeed\\\/avatar\\\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1777613206\",\"url\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/wp-content\\\/litespeed\\\/avatar\\\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1777613206\",\"contentUrl\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/wp-content\\\/litespeed\\\/avatar\\\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1777613206\",\"caption\":\"Kirat\"},\"sameAs\":[\"http:\\\/\\\/jassweb.com\"],\"url\":\"https:\\\/\\\/jassweb.com\\\/solved\\\/author\\\/jaspritsinghghumangmail-com\\\/\"}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","yoast_head_json":{"title":"[Solved] programming task ask [closed] - JassWeb","robots":{"index":"index","follow":"follow","max-snippet":"max-snippet:-1","max-image-preview":"max-image-preview:large","max-video-preview":"max-video-preview:-1"},"canonical":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/","og_locale":"en_US","og_type":"article","og_title":"[Solved] programming task ask [closed] - JassWeb","og_description":"[ad_1] There are a few issues here: Your program fails to compile because of the misplaced semi-colon in cout<<\"nNew String 2 is :\";<<b Your program crashes at strcpy(a,x); because you’re copying into a which is uninitialised – it has no memory allocated. You’d need to call new on a for this to work, which would ... Read more","og_url":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/","og_site_name":"JassWeb","article_published_time":"2022-09-21T19:08:52+00:00","author":"Kirat","twitter_card":"summary_large_image","twitter_misc":{"Written by":"Kirat","Est. reading time":"2 minutes"},"schema":{"@context":"https:\/\/schema.org","@graph":[{"@type":"Article","@id":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/#article","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/"},"author":{"name":"Kirat","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31"},"headline":"[Solved] programming task ask [closed]","datePublished":"2022-09-21T19:08:52+00:00","mainEntityOfPage":{"@id":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/"},"wordCount":207,"publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"keywords":["c++"],"articleSection":["Solved"],"inLanguage":"en-US"},{"@type":"WebPage","@id":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/","url":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/","name":"[Solved] programming task ask [closed] - JassWeb","isPartOf":{"@id":"https:\/\/jassweb.com\/solved\/#website"},"datePublished":"2022-09-21T19:08:52+00:00","breadcrumb":{"@id":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/#breadcrumb"},"inLanguage":"en-US","potentialAction":[{"@type":"ReadAction","target":["https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/"]}]},{"@type":"BreadcrumbList","@id":"https:\/\/jassweb.com\/solved\/solved-programming-task-ask-closed\/#breadcrumb","itemListElement":[{"@type":"ListItem","position":1,"name":"Home","item":"https:\/\/jassweb.com\/solved\/"},{"@type":"ListItem","position":2,"name":"[Solved] programming task ask [closed]"}]},{"@type":"WebSite","@id":"https:\/\/jassweb.com\/solved\/#website","url":"https:\/\/jassweb.com\/solved\/","name":"JassWeb","description":"Build High-quality Websites","publisher":{"@id":"https:\/\/jassweb.com\/solved\/#organization"},"potentialAction":[{"@type":"SearchAction","target":{"@type":"EntryPoint","urlTemplate":"https:\/\/jassweb.com\/solved\/?s={search_term_string}"},"query-input":{"@type":"PropertyValueSpecification","valueRequired":true,"valueName":"search_term_string"}}],"inLanguage":"en-US"},{"@type":"Organization","@id":"https:\/\/jassweb.com\/solved\/#organization","name":"Jass Web","url":"https:\/\/jassweb.com\/solved\/","logo":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/","url":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","contentUrl":"https:\/\/jassweb.com\/wp-content\/uploads\/2021\/02\/jass-website-logo-1.png","width":693,"height":132,"caption":"Jass Web"},"image":{"@id":"https:\/\/jassweb.com\/solved\/#\/schema\/logo\/image\/"}},{"@type":"Person","@id":"https:\/\/jassweb.com\/solved\/#\/schema\/person\/65c9c7b7958150c0dc8371fa35dd7c31","name":"Kirat","image":{"@type":"ImageObject","inLanguage":"en-US","@id":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1777613206","url":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1777613206","contentUrl":"https:\/\/jassweb.com\/solved\/wp-content\/litespeed\/avatar\/1261af3c9451399fa1336d28b98ea3bb.jpg?ver=1777613206","caption":"Kirat"},"sameAs":["http:\/\/jassweb.com"],"url":"https:\/\/jassweb.com\/solved\/author\/jaspritsinghghumangmail-com\/"}]}},"_links":{"self":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/10044","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/comments?post=10044"}],"version-history":[{"count":0,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/posts\/10044\/revisions"}],"wp:attachment":[{"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/media?parent=10044"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/categories?post=10044"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/jassweb.com\/solved\/wp-json\/wp\/v2\/tags?post=10044"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}